Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using inside of Electron App. #28

Open
markmorris opened this issue Oct 15, 2018 · 1 comment
Open

Using inside of Electron App. #28

markmorris opened this issue Oct 15, 2018 · 1 comment

Comments

@markmorris
Copy link

markmorris commented Oct 15, 2018

I'm trying to write an app that packages my apps.

So ive included this in an electron app. But when i try and run this code from the application it creates the .wsx with incorrect asar paths. It assumes .asar files are directories when compiled with electron.

For example when i run the script without electron, it looks like: (THIS IS CORRECT)
<File Name="app.asar" Id="resources_app.asar" Source="C:\Users\Lauran\Desktop\win-packager\win-packager\release-builds\the-x-factory-sing-it-win32-ia32\resources\app.asar" KeyPath="yes" Checksum="yes"/>

With Electron (THIS IS INCORRECT)
<Directory Id="resources_app.asar_.somefile" Name=".somefile">

It thinks all asar files are directories. Which is incorrect. I'm also using full paths for everything.

My assumption would be that electron contains asar dependencies and is causing them to get unpacked?

How can i work around this?

UPDATE:
I see the issue is related to klaw and is currently an open issue.
manidlou/node-klaw-sync#7

UPDATE 2:
According to the developers at klaw, the code in walker should have never worked, it is suppose to return a directory for .asar files, but running this script without electron returns them as files. I'm crazy lost to whats going on.

markmorris added a commit to markmorris/electron-wix-msi that referenced this issue Oct 15, 2018
Kinda hacky as its running in a loop, but works perfect for both usages. Better option would be to use filters in klaw. See electron-userland#28
@markmorris
Copy link
Author

Created a hacky fix here.
markmorris@94e22b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant