Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change filtering to treat base Contents directory the same as its subdirectories #247

Open
rpatrick00 opened this issue Jul 26, 2021 · 1 comment

Comments

@rpatrick00
Copy link

In working through a number of issues trying to get electron-builder to sign/notarize my application (which is packaged as a DMG installer), I ran into issues with text files in the Contents directory. I was hopeful when I found the -ignore option (surfaced in electron-builder as signIgnore). Unfortunately, what I found was:

  1. Files in the root MyApp.app/Contents directory cannot be filtered (i.e., the ignore() function is never called for them).
  2. Files in the subdirectories of MyApp.app/Contents are already being filtered (e.g., the ignore() function is never called for MyApp.app/Contents/tools/weblogic-deploy/LICENSE.txt but code signing is skipping the file automatically).

I don't understand the the rationale for this seemingly inconsistent behavior. You can see more details at electron-userland/electron-builder#6085.

@brnbs
Copy link

brnbs commented May 29, 2024

any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@rpatrick00 @brnbs and others