Skip to content

Commit

Permalink
Merge pull request #541 from vector-im/SimonBrandner/fix/full-screen
Browse files Browse the repository at this point in the history
  • Loading branch information
SimonBrandner authored Aug 19, 2022
2 parents 3406b46 + 5be0fde commit 1d7da9c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"classnames": "^2.3.1",
"color-hash": "^2.0.1",
"events": "^3.3.0",
"matrix-js-sdk": "github:matrix-org/matrix-js-sdk#3334c01191bcd82b5243916284c9a08d08fd9795",
"matrix-js-sdk": "github:matrix-org/matrix-js-sdk#45e56f8cc36c459ed43e405be4206e5e66b3ad98",
"matrix-widget-api": "^1.0.0",
"mermaid": "^8.13.8",
"normalize.css": "^8.0.1",
Expand Down
3 changes: 3 additions & 0 deletions src/video-grid/useCallFeed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ interface CallFeedState {
videoMuted: boolean;
audioMuted: boolean;
localVolume: number;
disposed: boolean;
stream: MediaStream;
purpose: SDPStreamMetadataPurpose;
}
Expand All @@ -37,6 +38,7 @@ function getCallFeedState(callFeed: CallFeed): CallFeedState {
videoMuted: callFeed ? callFeed.isVideoMuted() : true,
audioMuted: callFeed ? callFeed.isAudioMuted() : true,
localVolume: callFeed ? callFeed.getLocalVolume() : 0,
disposed: callFeed ? callFeed.disposed : undefined,
stream: callFeed ? callFeed.stream : undefined,
purpose: callFeed ? callFeed.purpose : undefined,
};
Expand Down Expand Up @@ -69,6 +71,7 @@ export function useCallFeed(callFeed: CallFeed): CallFeedState {
callFeed.on(CallFeedEvent.MuteStateChanged, onMuteStateChanged);
callFeed.on(CallFeedEvent.LocalVolumeChanged, onLocalVolumeChanged);
callFeed.on(CallFeedEvent.NewStream, onUpdateCallFeed);
callFeed.on(CallFeedEvent.Disposed, onUpdateCallFeed);
}

onUpdateCallFeed();
Expand Down
11 changes: 10 additions & 1 deletion src/video-grid/useFullscreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,19 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

import { useCallback, useState } from "react";
import { useCallback, useEffect, useState } from "react";

import { Participant } from "../room/InCallView";
import { useEventTarget } from "../useEvents";
import { useCallFeed } from "./useCallFeed";

export function useFullscreen(ref: React.RefObject<HTMLElement>): {
toggleFullscreen: (participant: Participant) => void;
fullscreenParticipant: Participant | null;
} {
const [fullscreenParticipant, setFullscreenParticipant] =
useState<Participant | null>(null);
const { disposed } = useCallFeed(fullscreenParticipant?.callFeed);

const toggleFullscreen = useCallback(
(participant: Participant) => {
Expand All @@ -52,5 +54,12 @@ export function useFullscreen(ref: React.RefObject<HTMLElement>): {

useEventTarget(ref.current, "fullscreenchange", onFullscreenChanged);

useEffect(() => {
if (disposed) {
document.exitFullscreen();
setFullscreenParticipant(null);
}
}, [disposed]);

return { toggleFullscreen, fullscreenParticipant };
}

0 comments on commit 1d7da9c

Please sign in to comment.