Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy path UI buttons are not autofocused #1622

Open
ara4n opened this issue Sep 26, 2023 · 1 comment
Open

Happy path UI buttons are not autofocused #1622

ara4n opened this issue Sep 26, 2023 · 1 comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Design

Comments

@ara4n
Copy link
Member

ara4n commented Sep 26, 2023

Steps to reproduce

The most common UI button should be focused by default so you can hit enter to rapidly select it

  • Join button when entering a call
  • Submit button when rageshaking (not the close button)
  • probably others

Outcome

What did you expect?

default focus on happy case UI flow

What happened instead?

no focus, or focus on unhappy case flows

Operating system

No response

Browser information

No response

URL for webapp

call.element.io

Will you send logs?

No

@fkwp fkwp added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Design labels Sep 27, 2023
@robintown
Copy link
Member

I ended up removing these autofocus behaviors recently because autofocus is often recommended against in accessibility guidelines, but there is certainly an argument to be had that our lobby view is one such exception where autofocus is still reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Design
Projects
None yet
Development

No branches or pull requests

3 participants