Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump matrix-js-sdk to v36.1.0 #2967

Open
wants to merge 4 commits into
base: livekit
Choose a base branch
from
Open

Bump matrix-js-sdk to v36.1.0 #2967

wants to merge 4 commits into from
+18 −17

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jan 23, 2025 •
edited by hughns
Loading

Fixes #2973.

Full diff of matrix-js-sdk: matrix-org/matrix-js-sdk@9134471...v36.1.0

@toger5 toger5 requested a review from a team as a code owner January 23, 2025 15:27
@toger5 toger5 requested a review from AndrewFerr January 23, 2025 15:27
@toger5 toger5 force-pushed the toger5/bump-js-sdk-make-ec-compatible-with-without-updatestate branch from c726eb7 to 578d68d Compare January 24, 2025 08:51
@toger5 toger5 force-pushed the toger5/bump-js-sdk-make-ec-compatible-with-without-updatestate branch from 578d68d to 892c4a3 Compare January 24, 2025 13:22
@hughns
Copy link
Member

hughns commented Jan 24, 2025

Marking draft so that this doesn't accidentally get merged. Known to break EX integration.

@hughns hughns marked this pull request as draft January 24, 2025 13:53
@toger5
Copy link
Contributor Author

toger5 commented Jan 24, 2025

Known to break EX integration.

This is not anymore the case because of:
matrix-org/matrix-js-sdk@eaca582

@hughns hughns changed the title Toger5/bump-js-sdk-make-ec-compatible-with-without-updatestate Bump matrix-js-sdk to v36.1.0-rc.0 Jan 27, 2025
@toger5
Copy link
Contributor Author

toger5 commented Jan 28, 2025

Is this also blocked on: matrix-org/matrix-js-sdk#4662

Since we reverted the changes that broke the awaiting on EX, I am wondering if this can get merged?
Is the initial state_update change part of the rc0

@hughns
Copy link
Member

hughns commented Jan 28, 2025

Is this also blocked on: matrix-org/matrix-js-sdk#4662

Since we reverted the changes that broke the awaiting on EX, I am wondering if this can get merged? Is the initial state_update change part of the rc0

I suggest waiting until v36.1.0 gets released and use that version rather the RC. Technically the reverted version is only in v36.1.0-rc.1 (not rc0) which hasn't actually been released.

@hughns hughns changed the title Bump matrix-js-sdk to v36.1.0-rc.0 Bump matrix-js-sdk to v36.1.0 Jan 29, 2025
@hughns hughns marked this pull request as ready for review January 29, 2025 11:08
@hughns hughns requested a review from robintown January 29, 2025 12:40
@hughns hughns enabled auto-merge (squash) January 29, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr Awaiting requested review from AndrewFerr AndrewFerr is a code owner automatically assigned from element-hq/element-call-reviewers

@robintown robintown Awaiting requested review from robintown

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update matrix-js-sdk to v36.1.0
2 participants
@toger5 @hughns