Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in height calculation for RTL text when there is headIndent and… #7289

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

toshanmugaraj
Copy link
Contributor

@toshanmugaraj toshanmugaraj commented Jan 22, 2023

Issue in height calculation for RTL text when there is headIndent and firstlineheadIndent. Fixes #7288

Signed-off-by: Shunmugaraj [email protected]

Pull Request Checklist

  • [ x] I read the contributing guide
  • [ x] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • [ x] Accessibility has been taken into account.
  • [ x] Pull request is based on the develop branch
  • [ x] Pull request contains a changelog file in ./changelog.d
  • [ x] You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • [x ] Pull request includes a sign off

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Base: 11.97% // Head: 11.97% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (006a7fa) compared to base (fdf1839).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7289   +/-   ##
========================================
  Coverage    11.97%   11.97%           
========================================
  Files         1634     1634           
  Lines       161007   161025   +18     
  Branches     65851    65857    +6     
========================================
+ Hits         19283    19286    +3     
- Misses      141083   141098   +15     
  Partials       641      641           
Flag Coverage Δ
uitests 55.34% <ø> (ø)
unittests 5.95% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m 16.97% <0.00%> (-0.13%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTL replies sometimes don't get rendered
2 participants