Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] ER-212: Show room encryption state in the composer #2746

Open
6 tasks
mxandreas opened this issue Feb 20, 2025 · 3 comments
Open
6 tasks

[Story] ER-212: Show room encryption state in the composer #2746

mxandreas opened this issue Feb 20, 2025 · 3 comments

Comments

@mxandreas
Copy link

mxandreas commented Feb 20, 2025

Description

The main goal of this is to mitigate the potential attacks on "downgrading" room encryption via cloning/spoofing of rooms as captured on https://github.com/matrix-org/internal-config/issues/1606.

It should be clear for the user if the room is E2EE when sending the message. Currently there is some indication on EW (a legacy shield and placeholder text of the composer) but nothing on EX, making it slightly less urgent for EW.

Designs are available here for all platforms (this story only concerns the decoration in the composer, potential decoration in other areas should be ignored). Illustration on iOS:

Image

Acceptance criteria

  • Composer shows room encryption state in/at the composer

Out of scope

  • Nothing

Open questions

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion
@manuroe
Copy link
Member

manuroe commented Feb 26, 2025

@stefanceriu @jmartinesp This is a bit close to the encryption decoration work you are doing. Can you update the composer hint and its icon?

@bmarty
Copy link
Member

bmarty commented Feb 27, 2025

Note a product owner, but I think we should not bother users about encryption/technical terms ("invisible crypto", etc.) so maybe stick to Message... for the hint and showing the padlock for e2e rooms is enough? Or using another term like "Secure message..." ? It will match what is used on the PlayStore: Element X - Secure Chat & Call.

@mxandreas
Copy link
Author

maybe stick to Message... for the hint and showing the padlock for e2e rooms is enough? Or using another term like "Secure message..." ? It will match what is used on the PlayStore: Element X - Secure Chat & Call.

Encryption is not a "technical term" in our context, we already use it in other places of the UI (e.g. Encryption menu, Encrypted pill in room info), and even in marketing materials since E2EE is one of our key differentiators. Therefore "Encrypted message" should be very clear and unambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants