Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.0 does not build with Rust 1.80 #3088

Closed
matrixbot opened this issue Sep 10, 2024 · 4 comments
Closed

v0.9.0 does not build with Rust 1.80 #3088

matrixbot opened this issue Sep 10, 2024 · 4 comments
Labels
T-Defect Something isn't working

Comments

@matrixbot
Copy link
Collaborator

This issue was originally created by @teutat3s at matrix-org/matrix-authentication-service#3088.

alyssais discovered that Rust 1.80.0 contains a couple of changes that break the build for matrtix-authentication-service. I'm opening this issue to coordinate efforts to make matrtix-authentication-service ready for 1.80.0.

Citing the linked issue:

Figure out what's broken. Usually, but not always, this is that the "time" crate needs to be updated.

   Compiling time v0.3.34
error[E0282]: type annotations needed for `Box<_>`

It looks like the time crate was already bumped to v0.3.36, so all that would be needed here should be a new release.

@matrixbot matrixbot added the T-Defect Something isn't working label Sep 10, 2024
@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @sandhose at matrix-org/matrix-authentication-service#3088 (comment).

You're in luck, I plan to cut 0.10.0 RC later today, with the stable version coming up next week :)

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @sandhose at matrix-org/matrix-authentication-service#3088 (comment).

We just cut 0.10.0-rc.0, can you try upgrading to it and report back?

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @teutat3s at matrix-org/matrix-authentication-service#3088 (comment).

I can confirm 0.10.0-rc.0 builds fine with Rust 1.80.0.

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @sandhose at matrix-org/matrix-authentication-service#3088 (comment).

Alright, I'm closing this issue then, as we'll release 0.10.0 stable in the coming days, and you can start upgrading to 0.10.0-rc.0 in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant