Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract GitHub Actions scripts in separate files and lint them #3846

Closed
sandhose opened this issue Jan 22, 2025 · 1 comment
Closed

Extract GitHub Actions scripts in separate files and lint them #3846

sandhose opened this issue Jan 22, 2025 · 1 comment
Labels
A-CI Related to continuous integration/GitHub Actions T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@sandhose
Copy link
Member

We have a few places where we use actions/github-script with inline JS. These are error-prone, as we have no linter or typechecker on those scripts.

We should extract them, and make sure we run them through biome & tsc
@sandhose sandhose added A-CI Related to continuous integration/GitHub Actions T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jan 22, 2025
@sandhose
Copy link
Member Author

sandhose commented Feb 7, 2025

Did that in #3973

@sandhose sandhose closed this as completed Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CI Related to continuous integration/GitHub Actions T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sandhose