Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config should yell and warn about float values being cast to ints #18164

Open
MadLittleMods opened this issue Feb 14, 2025 · 0 comments
Open

Config should yell and warn about float values being cast to ints #18164

MadLittleMods opened this issue Feb 14, 2025 · 0 comments
Labels
A-Config T-Defect

Comments

@MadLittleMods
Copy link
Contributor

Wherever an int is used for a config value, if someone accidentally provides a float number value, it will get floored (rounded down).

This can lead to misconfigurations like specifying 0.5 for the rate limiting burst_count which will get rounded down to 0 and not allow requests at all (real example: #18159).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Config T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MadLittleMods