Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual light/dark style override #6

Open
cassidyjames opened this issue Sep 17, 2019 · 3 comments
Open

Manual light/dark style override #6

cassidyjames opened this issue Sep 17, 2019 · 3 comments

Comments

@cassidyjames
Copy link
Contributor

From https://github.com/elementary/blog/issues/12

Should be relatively easy to do with lightweight js and local storage

@michallepicki
Copy link
Contributor

I could pick this one up someday but if someone else wants to do this, here's how it's done in Elixir's ex_doc documentation generator. Effect here - there's a "Toggle night mode" link in the footer. You would just need to use plain js instead of jquery.

moshenskyDV pushed a commit to moshenskyDV/blog-template that referenced this issue Oct 6, 2019
@moshenskyDV
Copy link

I've created PR #17
Maybe I should wrap the night mode code to scss mixins to prevent code duplicate? Or right now is ok?

@cassidyjames
Copy link
Contributor Author

@moshenskyDV thanks! I've left a review on the PR.

moshenskyDV pushed a commit to moshenskyDV/blog-template that referenced this issue Oct 7, 2019
moshenskyDV pushed a commit to moshenskyDV/blog-template that referenced this issue Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants