Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker hello-world cleanup #16

Open
KasperZutterman opened this issue Dec 10, 2020 · 3 comments
Open

Docker hello-world cleanup #16

KasperZutterman opened this issue Dec 10, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@KasperZutterman
Copy link

When running the go.sh script, method test_docker_available() runs:
docker run hello-world > /dev/null 2>&1 to test if docker is configuered correctly.
This test container never gets cleaned up, resulting in a bunch of hello-world containers:
image

@leonstafford
Copy link
Contributor

yikes! Thanks for that, @KasperZutterman! Feel free to send a pull request if you want to submit some code to fix it, else, I'll take a look at it soon

@leonstafford
Copy link
Contributor

mine:

docker ps -a | grep 'hello' | wc -l
88

haha! and that's with some occasional bulk cleanup

@leonstafford leonstafford added the bug Something isn't working label Dec 10, 2020
KasperZutterman added a commit to KasperZutterman/go that referenced this issue Dec 10, 2020
@KasperZutterman
Copy link
Author

I've created the following pull request in the correct repo.
Hope the solution is sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants