Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts along seams when relighitng #1

Open
yoterel opened this issue Apr 14, 2023 · 1 comment
Open

Artifacts along seams when relighitng #1

yoterel opened this issue Apr 14, 2023 · 1 comment

Comments

@yoterel
Copy link

yoterel commented Apr 14, 2023

Hello, thanks for this implementation !

I have ran the entire code on my own setup, but encountered a strange phenomenon of artifacts between pixels when relighting using patterns that are not "all 1's". This reproduced for 2 different scenes but does not happen with the provided data.

Have you seen such artifacts or have a way to counter this? any help would be appreciated.

Attached some photos to show what I mean (first image: synthetic image created from shining all 1's (works), 2nd,3rd: new synthetic lights that were used, 4th 5th: the synthetic image created by this implementation projecting these two lights). Notice the artifacts created where the light isn't shining.

orig
projected_00
projected_01
show2
show1

@elerac
Copy link
Owner

elerac commented Apr 17, 2023

Hello, @yoterel

Great implementation in your setup.

I'm sorry, but I don't know the exact reason for that weird artifact. I haven't encountered such a problem.

I guess you should

  • Increase the number of projection patterns (1.5 to 2.0 times more than the minimum requirement). It can be robust against noise, and your artifact may be suppressed.

Additionally, make sure when you capture the images.

  • Set the camera setting manually (i.e., exposure time, gain (iso), aperture, white balance). Do not rely on auto. It may change the setting while capturing sequential images.
  • Disable the gamma correction. While estimating the light transport matrix, I assume the camera response function is linear.
  • If you use a DMD or laser scanning-based projector, you must consider the camera's exposure time. Check the raw image, and it does not have a weird pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants