Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with downloading of large files #59

Open
andrazrepar opened this issue May 24, 2022 · 3 comments
Open

Issue with downloading of large files #59

andrazrepar opened this issue May 24, 2022 · 3 comments
Assignees

Comments

@andrazrepar
Copy link
Collaborator

The current workflow is as follows:

  • click Download, select one of the two options and wait
  • After the file is prepared, click Download button, wait for the file to download and in the meantime the download status resets and the user can start again.

However, with large files, after the file is prepared and the user clicks the Download button, it takes a few seconds to start the download and in the meantime the screen refreshes and the user already sees the two initial options (with or without namespaces). This is confusing because it seems that immediately clicking one of the two options again cancels the download.

I guess we need to prevent the screen from being refreshed until after the download starts.

@gradisarjoze
Copy link
Collaborator

  1. When use clicks download with whichever option, the status of the file is set to Processing.
  2. Anytime the application opens the "Download popup" it asks about the status of the dictionary, if it's processing, its waiting, if it's ready it presents a download button. If status is none of those, the popup asks you to select with/without namespaces.

This could be an API issue.

@andrazrepar
Copy link
Collaborator Author

@LukeItUp is it possible that the status resets before the download starts? Can we delay it somehow so that the with/without namespaces messages does not show until the download has actually started?

@LukeItUp
Copy link
Collaborator

Dictionary's status resets when the file starts being served to the client (user). What you are suggesting is changing status after the downloaded file has been served i.e. the request has been fully processed. Flask sadly does not directly support this.
Things we could do:

  • delay dictionary status update for X amount of seconds when download request is being processed
  • send an automatic confirmation request from FE to change the status after the download file response has been received

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants