Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to use libnatspec for code page detection (maybe even conversion) instead of using hardcoded values #1800

Open
unxed opened this issue Aug 15, 2023 · 5 comments

Comments

@unxed
Copy link
Contributor

unxed commented Aug 15, 2023

I am talking about DeduceCodepages(). At the moment there are hardcoded conversion tables. But, in general, it would be logical to move such things related to working with locales from Wine to a separate library. libnatspec is just such a library.

Etersoft/libnatspec#3

@unxed
Copy link
Contributor Author

unxed commented Aug 15, 2023

This library can also be used for charset conversion instead of borrowing Wine code directly.

@unxed unxed changed the title add an option to use libnatspec for code page detection instead of using hardcoded values add an option to use libnatspec for code page detection (maybe even conversion) instead of using hardcoded values Aug 15, 2023
@elfmz
Copy link
Owner

elfmz commented Aug 15, 2023

This library can also be used for charset conversion instead of borrowing Wine code directly.

performance is the question

@unxed
Copy link
Contributor Author

unxed commented Aug 15, 2023

Back in the days of the iconv branch, there seemed to be some performance testing tools that showed that iconv was slower. Can you apply the same tools to libnatspec?

@elfmz
Copy link
Owner

elfmz commented Aug 15, 2023

Its possible, but whats problem with current solution, that may be fixed by using yet another library?

@unxed
Copy link
Contributor Author

unxed commented Aug 15, 2023

  1. libnatspec has more complete code pages info I guess
  2. no need to sync such info with Wine from time to time

@vitlav probably can suggest other advantages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants