Use Magento Translations for text checks #115
norgeindian
started this conversation in
Ideas
Replies: 1 comment 2 replies
-
@peterjaap , what do you think? Would that be an idea? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We're currently adapting the base setup for one of our projects.
As we don't have the Magento sample data there, it's obvious that we need to adapt selectors, identifiers and so on and that's totally fine.
But while doing this, we find very often, that we just need to replace the existing text with the translation.
So for example there is in
cypress/integration/luma/cart/cart.spec.js
the check forYou have no items in your shopping cart.
.As the translation exists in the Magento system, would it be an idea to somehow get this translation and compare the given text to the translation instead of the fixed text?
I think, this would decrease the need for adapting the module for different projects.
What do you think?
Beta Was this translation helpful? Give feedback.
All reactions