Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper ping function implementation #3

Closed
kaolpr opened this issue Dec 17, 2024 · 2 comments
Closed

Add proper ping function implementation #3

kaolpr opened this issue Dec 17, 2024 · 2 comments
Assignees

Comments

@kaolpr
Copy link
Member

kaolpr commented Dec 17, 2024

This function should communicate with the device (e.g. read device model) and return True if the response was as expected. See ARTIQ manual for details.

@mmalczak
Copy link
Collaborator

In this manual:
https://m-labs.hk/artiq/manual/developing_a_ndsp.html
there is the following description:

In order to be correctly started and stopped by a controller manager, your controller must additionally implement a ping() method, which should simply return true, e.g.
def ping(self):
return True

Could you please point me to the manual you mean, with proper description?

@mmalczak mmalczak assigned kaolpr and unassigned mmalczak Dec 17, 2024
@mmalczak
Copy link
Collaborator

Nevermind, I will take different NDSP as an example.

@mmalczak mmalczak assigned mmalczak and unassigned kaolpr and mmalczak Dec 17, 2024
mmalczak added a commit that referenced this issue Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants