Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Open File Dialog and Line Selection #47

Open
eks-99th opened this issue Oct 5, 2024 · 3 comments
Open

Feature: Open File Dialog and Line Selection #47

eks-99th opened this issue Oct 5, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@eks-99th
Copy link

eks-99th commented Oct 5, 2024

Open File Window Feature

As a user of Basil, it would be highly convenient to have the ability to select the Specification URL/Path and Implementation File URL/Path using an "Open File" dialog. This feature would allow users to easily browse and select files from their local system, rather than manually entering file paths.

Line Selection in the Web UI

For text-based implementation files, it would be beneficial to open the file directly in the web interface and allow users to select specific lines, similar to how line selection works in GitHub’s PR review. This would eliminate the need to manually open the file, find the line numbers, and copy them into the web interface.

@pellecchialuigi
Copy link
Collaborator

Hi @eks-99th thanks for filing this issue.
That's a good point.
As I understand your suggestion, you would like to let users able to select files on their own machines and not browsing the filesystem of the BASIL-API instance, right?

If I understood that correctly, we should allow user to upload files in a default location (something configurable at the container file build time).

I would like to still keep the possibility to manually edit the field as people are also using remote files.

So a solution can be to add a button/link close to the fields to browse the filesystem.

Would you like to contribute developing this feature?

@eks-99th
Copy link
Author

eks-99th commented Oct 7, 2024

Hello @pellecchialuigi,

Yes, I your understanding of the feature is similar to mine. I see it as a low-hanging fruit that could add some value to the project. I’m interested in contributing to this feature, but I plan to start in December 2024. I would also need some time to get up to speed, as my background is in embedded development, so there will be a bit of a learning curve for me.

@pellecchialuigi
Copy link
Collaborator

Hi @eks-99th,
no worries, I can add this feature to my todo list and It will be great to have you as reviewer.
Feel free to contribute to the project as you have time or needs.
You're anytime welcome!

@pellecchialuigi pellecchialuigi added the enhancement New feature or request label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants