Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove dash app #90

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Feat/remove dash app #90

wants to merge 16 commits into from

Conversation

pdmnyberg
Copy link
Collaborator

@pdmnyberg pdmnyberg commented Jan 2, 2025

This PR closes #52 and #66

It will:

  • Remove metrics middleware to simplify system structure
  • Remove dash dependency
  • Remove pandas and numpy dependency
  • Calculate metrics using SQL and standard python instead of pandas/numpy
  • Move plotly scripts into repository in order to make the system properly standalone
  • Change download functionality to download the entire metrics result for the current superset

To test:

  • start development environment
  • make sure the world map works as expected
  • make sure the metrics filtering works as expected
  • make sure the download, on the metrics pages, work as expected

@pdmnyberg pdmnyberg marked this pull request as draft January 2, 2025 16:10
@pdmnyberg pdmnyberg force-pushed the feat/remove-dash-app branch from 44322f3 to 5af2ec7 Compare January 14, 2025 10:10
@pdmnyberg pdmnyberg force-pushed the feat/remove-dash-app branch from 0a9fbb4 to c6542a1 Compare January 14, 2025 12:50
@pdmnyberg pdmnyberg marked this pull request as ready for review January 14, 2025 12:51
@pdmnyberg pdmnyberg force-pushed the feat/remove-dash-app branch from 4425103 to a06e38f Compare January 14, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant