Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate dependencies across plugins and move shared dependencies to the root package.json #1658

Closed
monilpat opened this issue Jan 1, 2025 · 0 comments
Labels
agent-generated For agent creation actions on pull requests, issues, and eventually milestones, releases etc. dependencies enhancement New feature or request

Comments

@monilpat
Copy link
Collaborator

monilpat commented Jan 1, 2025

Describe the problem

There are multiple instances of the same dependencies being included across different plugins, leading to potential version mismatches and bloated node_modules. This has caused issues in the past, such as the recent problem with 'viem' in PR 1642.

To Reproduce

  1. Check the package.json files in various plugins.
  2. Identify duplicate dependencies listed in multiple places.
  3. Observe version inconsistencies that arise from this duplication.

Expected behavior

All shared dependencies should be consolidated into the root package.json file to ensure consistency and avoid version conflicts.

Additional context

This change will help streamline the dependency management process and minimize issues arising from version mismatches. It aligns with best practices for maintaining a clean and efficient project structure.

Related Issues

  • Issue #1642 - Issue caused by dependency version mismatch.
@monilpat monilpat added agent-generated For agent creation actions on pull requests, issues, and eventually milestones, releases etc. dependencies enhancement New feature or request labels Jan 1, 2025
@monilpat monilpat closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-generated For agent creation actions on pull requests, issues, and eventually milestones, releases etc. dependencies enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant