Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Opening a window that is already open closes and reopens it, causing flickering #892

Open
3 tasks done
skiletro opened this issue Aug 22, 2023 · 1 comment · May be fixed by #1120
Open
3 tasks done

[BUG] Opening a window that is already open closes and reopens it, causing flickering #892

skiletro opened this issue Aug 22, 2023 · 1 comment · May be fixed by #1120
Labels
bug Something isn't working

Comments

@skiletro
Copy link

Checklist before submitting an issue

  • I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
  • I have specifically verified that this bug is not a common user error
  • I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug

Running eww open on a window that is already open will cause the window to close and then reopen causing flickering. Seems to had been fixed a while ago in #263 but it still seems to be an issue.

Reproducing the issue

Running eww open on an already open window will cause it, however I noticed it when using the new --duration flag.

Expected behaviour

Opening a window that is already open should just keep the window open without first closing it.
In the case of the --duration flag, it should just reset the duration the window should be open for.

Additional context

Noticed it while using eww to create a custom volume/brightness OSD. Running the eww open osd --duration 2000 command I noticed the flickering, and after checking eww logs it confirmed my suspicion. If there is a better way to do this, excuse my ignorance with this bug report.
@skiletro skiletro added the bug Something isn't working label Aug 22, 2023
BeneSim added a commit to BeneSim/eww that referenced this issue Jun 18, 2024
@BeneSim
Remove window flicker from open command
eac4e0f 
This solves a problem that had been already solved in
0d1b5e0 but was reintroduced in
a9a35c1. Basically before this, the
window has been closed and reopened if it existed, which results in
flickering due to the animations.

In addition to remove the window flicker the timer (if started with
--duration) will also be renewed. This fixes elkowar#892.
BeneSim added a commit to BeneSim/eww that referenced this issue Jun 18, 2024
@BeneSim
Remove window flicker from open command
8f1cd1a 
This solves a problem that had been already solved in
0d1b5e0 but was reintroduced in
a9a35c1. Basically before this, the
window has been closed and reopened if it existed, which results in
flickering due to the animations.

In addition to remove the window flicker the timer (if started with
--duration) will also be renewed. This fixes elkowar#892.
@BeneSim BeneSim linked a pull request Jun 18, 2024 that will close this issue
Open
4 tasks
@BeneSim
Copy link

BeneSim commented Jun 18, 2024

Faced exactly the same issue. I hacked up a fix for this, until this is merged you might want to try my feature branch / fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove window flicker and extend duration with open command BeneSim/eww
2 participants
@skiletro @BeneSim