Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events.on documentation wrong and function seems wrong too #34

Open
colwem opened this issue Jun 13, 2019 · 1 comment
Open

Events.on documentation wrong and function seems wrong too #34

colwem opened this issue Jun 13, 2019 · 1 comment

Comments

@colwem
Copy link

colwem commented Jun 13, 2019

The documentation says both that the second arg is a Handler and that it's a Decoder a. The interface for all other packages like this is Decoder a It probably should be. But it isn't.|

Should maybe be

on : String -> Json.Decode.Decoder msg -> TypedSvg.Core.Attribute msg
on event decoder =
    VirtualDom.on event (VirtualDom.Normal decoder)

and not

on : String -> VirtualDom.Handler msg -> VirtualDom.Attribute msg
on =
    VirtualDom.on
@colwem colwem changed the title Events.on documentation wrong and functions seems wrong too Events.on documentation wrong and function seems wrong too Jun 13, 2019
@mingan
Copy link
Contributor

mingan commented Jun 22, 2020

Synced by #41 in favour of the code signature, not the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants