From 5b77bda3e21804ac7e661c6ac32fe41bf6c98a35 Mon Sep 17 00:00:00 2001 From: Yong Bakos Date: Sat, 8 Apr 2017 09:42:36 -0700 Subject: [PATCH 1/3] style-guide: Rename 'bad' function to match 'good' example. --- src/pages/docs/style-guide.elm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/docs/style-guide.elm b/src/pages/docs/style-guide.elm index 1f11511d3..9b71742e1 100644 --- a/src/pages/docs/style-guide.elm +++ b/src/pages/docs/style-guide.elm @@ -77,7 +77,7 @@ the result will still look quite nice. ```elm homeDirectory = "/root/files" -eval boolean = case boolean of +evaluate boolean = case boolean of Literal bool -> bool Not b -> not (eval b) And b b_ -> eval b && eval b_ From bd777783ac44ae56403b08c11ff50a8b698059e5 Mon Sep 17 00:00:00 2001 From: Yong Bakos Date: Sat, 8 Apr 2017 09:45:28 -0700 Subject: [PATCH 2/3] style-guide: Clarify 'later' Massage the writing for clarity. Fixes #702. --- src/pages/docs/style-guide.elm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/docs/style-guide.elm b/src/pages/docs/style-guide.elm index 9b71742e1..59316a9eb 100644 --- a/src/pages/docs/style-guide.elm +++ b/src/pages/docs/style-guide.elm @@ -88,9 +88,9 @@ We saved vertical lines here, but at the cost of regularity and ease of modification. If `Literal` ever becomes longer, all arrows must move. If any branch gets too long, everything needs to come down a line anyway. -Having `case` appear *later* than the actual cases is strongly discouraged. It +Having `case` appear further to the right than the actual cases is strongly discouraged. It should serve as a context clue that makes glancing through code easy, but when -indented in crazy ways, it becomes more difficult to glance through. +indented or positioned in crazy ways, it becomes more difficult to glance through. ## Types From 4bea95210244bef03f304597c2f93a5bcafe4961 Mon Sep 17 00:00:00 2001 From: Yong Bakos Date: Sat, 8 Apr 2017 09:45:58 -0700 Subject: [PATCH 3/3] style-guide: Adjust line length. --- src/pages/docs/style-guide.elm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/pages/docs/style-guide.elm b/src/pages/docs/style-guide.elm index 59316a9eb..49c5eebba 100644 --- a/src/pages/docs/style-guide.elm +++ b/src/pages/docs/style-guide.elm @@ -88,9 +88,10 @@ We saved vertical lines here, but at the cost of regularity and ease of modification. If `Literal` ever becomes longer, all arrows must move. If any branch gets too long, everything needs to come down a line anyway. -Having `case` appear further to the right than the actual cases is strongly discouraged. It -should serve as a context clue that makes glancing through code easy, but when -indented or positioned in crazy ways, it becomes more difficult to glance through. +Having `case` appear further to the right than the actual cases is strongly +discouraged. It should serve as a context clue that makes glancing through code +easy, but when indented or positioned in crazy ways, it becomes more difficult +to glance through. ## Types