Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geom_turn() should sound a warning when attempting to plot multiple sources #79

Open
mdingemanse opened this issue Aug 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mdingemanse
Copy link
Contributor

Right now geom_turn() will merrily plot whatever you serve it. Whether it is a single source:

  dplyr::filter(source == "/dutch2/DVA9M") |>
  dplyr::filter(end < 60000) |>
  ggplot(aes(x = end, y = participant)) +
  geom_turn(aes(
    begin = begin,
    end = end)) +
  xlab("Time (ms)") +
  ylab("") +
  theme_turnPlot()

Or the whole dataset, merging things from multiple sources, which doesn't make sense:

data |>
  ggplot(aes(x = end, y = participant)) +
  geom_turn(aes(
    begin = begin,
    end = end)) +
  xlab("Time (ms)") +
  ylab("") +
  theme_turnPlot()

image

I think in a case like the latter, where multiple conversations risk being plotted over each other, geom_turn() should issue a warning:

Looks like you're trying to plot turns from multiple conversations. For better results, try to plot a single source, or facet by source.

@mdingemanse mdingemanse changed the title geom_turn should sound a warning when attempting to plot multiple sources geom_turn() should sound a warning when attempting to plot multiple sources Aug 20, 2024
@mdingemanse mdingemanse added the bug Something isn't working label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant