Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a basic test suite #15

Open
andrewpatto opened this issue Nov 14, 2023 · 1 comment
Open

Add a basic test suite #15

andrewpatto opened this issue Nov 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@andrewpatto
Copy link
Member

This functionality uses a lot of native AWS functionality (Steps distributed maps, restoring s3 objects etc) - so I don't think it is possible to make a mock test setup.

But we should make a test suite that can run which creates actual temp objects in a bucket and then copies
@andrewpatto andrewpatto added the enhancement New feature or request label Nov 14, 2023
@andrewpatto andrewpatto moved this to 📋 Backlog in Elsa Data Nov 29, 2023
@andrewpatto andrewpatto moved this from 📋 Backlog to 🆕 Ideas in Elsa Data Nov 29, 2023
@andrewpatto
Copy link
Member Author

There are some tests here and there - so we are in a better state - but still not quite as rigorous as I would like. Keeping this open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Elsa Data
Status: 🆕 Ideas
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewpatto