Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve page title handling #123

Open
elstoc opened this issue Jun 5, 2024 · 1 comment
Open

Improve page title handling #123

elstoc opened this issue Jun 5, 2024 · 1 comment

Comments

@elstoc
Copy link
Owner

elstoc commented Jun 5, 2024

Page title is set based on a useEffect hook that will only fire if the props of a component change. However, if a sub-component attempts to override the title of a higher-level component, and is then unmounted, the higher-level useEffect won't necessarily re-fire and update the title to its previous value.

@elstoc
Copy link
Owner Author

elstoc commented Jul 17, 2024

Perhaps a global context with the page title is the best way to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant