Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to keep default isearch behavior in REPL buffers #553

Open
egr95 opened this issue Aug 2, 2024 · 1 comment · May be fixed by #554
Open

Add an option to keep default isearch behavior in REPL buffers #553

egr95 opened this issue Aug 2, 2024 · 1 comment · May be fixed by #554

Comments

@egr95
Copy link

egr95 commented Aug 2, 2024

Thanks for the awesome package!

I am a heavy user of emacs-jupyter REPLs. I occasionally find that I want to navigate the output history using isearch, however the function (jupyter-repl-isearch-setup), which is called when the REPL is created, changes the behavior of isearch to operate only on the REPL command history rather than the entire REPL buffer itself.

Could we add an option to disable this override? In other words, to keep the standard behavior of isearch.

Not sure what would be a good naming convention but happy to submit a PR.

@egr95 egr95 linked a pull request Aug 3, 2024 that will close this issue
@egr95
Copy link
Author

egr95 commented Aug 22, 2024

It would be even nicer if one could keep the usual isearch behavior mapped to C-s/C-r, but add the additional jupyter-repl-history-isearch-search under a different binding, e.g., S-C-s/S-C-r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant