Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell about auto-resolving lsp-sourcekit-executable #13

Merged
merged 2 commits into from
Jan 30, 2021
Merged

tell about auto-resolving lsp-sourcekit-executable #13

merged 2 commits into from
Jan 30, 2021

Conversation

DivineDominion
Copy link
Contributor

I think I'm actually resolving the path lazily with my settings so that this doesn't increase startup time:

(use-package swift-mode
  :hook (swift-mode . lsp-deferred))
(use-package lsp-sourcekit
  :after (swift-mode lsp-mode)
  :config
  (setq lsp-sourcekit-executable (string-trim-right (shell-command-to-string "xcrun --find sourcekit-lsp") "\n")))

Copy link
Collaborator

@danielmartin danielmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I have a small suggestion and we can merge it.

Co-authored-by: Daniel Martín <[email protected]>
@DivineDominion
Copy link
Contributor Author

@danielmartin Thanks for the fix! You're right about the default trim behavior. Not sure what I did wrong that led me to the oddly specialized call.

@danielmartin danielmartin merged commit d4a9b6b into emacs-lsp:master Jan 30, 2021
@danielmartin
Copy link
Collaborator

@DivineDominion Thanks for your contribution!

@DivineDominion DivineDominion deleted the patch-1 branch February 3, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants