Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used alongside ember-cli-revision-data and the git-tag-commit-generator the outputPathFor method fails #13

Open
Duder-onomy opened this issue Mar 28, 2018 · 0 comments

Comments

@Duder-onomy
Copy link

Duder-onomy commented Mar 28, 2018

Great addon! Thanks for doing this.

When using this in a fastboot server, and also using ember-cli-revision-data's non default options, specifically the revision type alongside a - separator, the outputPathFor method returns an incorrect path.

For Example, Im my ember apps, config/deploy.js

    'revision-data': {
      type: 'version-commit',
      separator: '-',
    },

Using https://github.com/ember-cli-deploy/ember-cli-deploy-fastboot-app-server-aws and deploying generates this zip file : dist-1.0.16-136a105c.zip The 1.0.16 in there is the version number in our app.

When fastboot s3 downloader unzips this file, it thinks that the unzipped contents live at dist-1.0.16 when in fact, they just live at dist.

The command to install npm dependencies fails as the output path is incorrect.

I think that the outputForPath method should be smarter OR maybe we should unzip into a directory that the fastboot-app-server specifies.

Hope this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant