You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using this in a fastboot server, and also using ember-cli-revision-data's non default options, specifically the revision type alongside a - separator, the outputPathFor method returns an incorrect path.
Great addon! Thanks for doing this.
When using this in a fastboot server, and also using ember-cli-revision-data's non default options, specifically the revision type alongside a
-
separator, theoutputPathFor
method returns an incorrect path.For Example, Im my ember apps,
config/deploy.js
Using https://github.com/ember-cli-deploy/ember-cli-deploy-fastboot-app-server-aws and deploying generates this zip file :
dist-1.0.16-136a105c.zip
The 1.0.16 in there is the version number in our app.When fastboot s3 downloader unzips this file, it thinks that the unzipped contents live at
dist-1.0.16
when in fact, they just live atdist
.The command to install npm dependencies fails as the output path is incorrect.
I think that the
outputForPath
method should be smarter OR maybe we should unzip into a directory that the fastboot-app-server specifies.Hope this makes sense.
The text was updated successfully, but these errors were encountered: