Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start DCSpy client as QThread #336

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Start DCSpy client as QThread #336

wants to merge 46 commits into from

Conversation

emcek
Copy link
Owner

@emcek emcek commented Jul 6, 2024

Description

Start DCSpy client as QThread

Todo

  • Tests
  • Documentation

@emcek emcek added the internal Internal changes label Jul 6, 2024
@emcek emcek added this to the Release 3.5.2 milestone Jul 6, 2024
@emcek emcek self-assigned this Jul 6, 2024
@coveralls
Copy link

Coverage Status

coverage: 96.277%. remained the same
when pulling 84b5e4e on client_in_qthread
into a9e33d4 on master.

@coveralls
Copy link

coveralls commented Jul 13, 2024

Coverage Status

coverage: 95.066% (-0.9%) from 96.004%
when pulling 0725ba9 on client_in_qthread
into f13819a on master.

emcek added 23 commits July 14, 2024 22:15
This commit updates code to improve error handling and status reporting. It introduces a SignalHandler class to coordinate between different Qt signals and slot connections. Additionally, all formatted tracebacks have been converted to strings and instances of the Thread class have been replaced by QRunnable instances for better compatibility with Qt. Several GUI elements have also been updated to provide more informative status messages and error reports.
…abel with blinking functionality. The color of the blinking light can be customized and the blink function can be called to toggle the label's state. This class will facilitate the creation of UI elements with more interactive features.
@emcek emcek removed this from the Release 3.5.2 milestone Aug 30, 2024
# Conflicts:
#	.pre-commit-config.yaml
#	CHANGELOG.md
#	dcspy/qt_gui.py
#	requirements_test.txt
# Conflicts:
#	src/dcspy/logitech.py
#	src/dcspy/qt_gui.py
#	src/dcspy/starter.py
#	src/dcspy/utils.py
Copy link

sonarcloud bot commented Sep 29, 2024

emcek and others added 7 commits November 4, 2024 15:03
# Conflicts:
#	CHANGELOG.md
#	src/dcspy/dcsbios.py
#	src/dcspy/qt_gui.py
#	src/dcspy/utils.py
#	tests/test_utils.py
#	uv.lock
# Conflicts:
#	src/dcspy/qt_gui.py
#	src/dcspy/starter.py
Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #336 will degrade performances by 26.91%

Comparing client_in_qthread (0725ba9) with master (9abab3b)

Summary

❌ 83 regressions
✅ 274 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master client_in_qthread Change
test_check_all_aircraft_inherit_from_correct_base_class[a10c2] 99.4 µs 114 µs -12.82%
test_check_all_aircraft_inherit_from_correct_base_class[a10c] 99.3 µs 111.9 µs -11.27%
test_check_all_aircraft_inherit_from_correct_base_class[ah64dblkii] 98.2 µs 110.9 µs -11.43%
test_check_all_aircraft_inherit_from_correct_base_class[av8bna] 98.2 µs 114 µs -13.9%
test_check_all_aircraft_inherit_from_correct_base_class[f14a135gr] 98.4 µs 111 µs -11.39%
test_check_all_aircraft_inherit_from_correct_base_class[f14b] 98.2 µs 111.3 µs -11.83%
test_check_all_aircraft_inherit_from_correct_base_class[f15ese] 98.2 µs 111.2 µs -11.67%
test_check_all_aircraft_inherit_from_correct_base_class[f4e45mc] 98.2 µs 110.7 µs -11.25%
test_check_all_aircraft_inherit_from_correct_base_class[fa18chornet] 99.8 µs 112.7 µs -11.41%
test_check_all_aircraft_inherit_from_correct_base_class[ka503] 97.9 µs 111.1 µs -11.82%
test_check_all_aircraft_inherit_from_correct_base_class[ka50] 98.5 µs 111 µs -11.27%
test_check_all_aircraft_inherit_from_correct_base_class[mi8mt] 98.5 µs 112.5 µs -12.41%
test_control_key_data_from_control[AAP_CDUPWR] 193 µs 216.2 µs -10.76%
test_control_key_data_from_control[AAP_PAGE] 170 µs 195.8 µs -13.2%
test_control_key_data_from_control[AAP_STEER] 138.6 µs 169.5 µs -18.2%
test_control_key_data_from_control[ADI_PITCH_TRIM] 146.9 µs 177.8 µs -17.38%
test_control_key_data_from_control[ARC210_CHN_KNB] 139.4 µs 170.2 µs -18.08%
test_control_key_data_from_control[PLT_WIPER_OFF] 170.3 µs 194.8 µs -12.58%
test_control_key_data_from_control[RIO_HCU_DDD] 190 µs 214 µs -11.25%
test_control_key_data_from_control[TACAN_1] 164.3 µs 187.7 µs -12.48%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

(cherry picked from commit 9abab3b)
Copy link

sonarcloud bot commented Nov 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants