Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod Compat] EMI centers "strict" crafting recipes #798

Open
Xefyr0 opened this issue Dec 7, 2024 · 0 comments
Open

[Mod Compat] EMI centers "strict" crafting recipes #798

Xefyr0 opened this issue Dec 7, 2024 · 0 comments
Labels
safe Low priority, may take some time

Comments

@Xefyr0
Copy link

Xefyr0 commented Dec 7, 2024

In both GregTech: Modern and in KubeJS, recipes are/can be defined that require items to be placed in specific locations of the Crafting Table - shifting the recipes horizontally or vertically will not produce the same result.
Despite this, EMI centers the recipes before displaying them, misinforming the player.

Versions:

Minecraft version: 1.20.1
Forge version: 47.3.12
EMI version: 1.1.18
Gregtech: Modern 1.5.4
Architectury 9.2.14
KubeJS 2001.6.5-build.16
Rhino 2001.2.3-build.6

GregTech: Modern

For an example from GregTech: Modern, we have the recipes for unpacking normal dust piles into small and tiny dust piles.
The recipes are defined in lines 245-293 of MaterialRecipeHandler.java:
https://github.com/GregTechCEu/GregTech-Modern/blob/3d6074670e3723c19736909e924b4719c6ffbf6f/src/main/java/com/gregtechceu/gtceu/data/recipe/generated/MaterialRecipeHandler.java#L245

EMI displays the recipe as requiring the normal dust in the very center of the table:
emi_asga

However, there are no such recipes:
emi_false_asga

Instead, the normal dust should be placed in one of the first two slots of the grid:
emi_true_asga_1
emi_true_asga_2

KubeJS

For an example from KubeJS, we have a custom recipe that converts some Cobblestone into Diamonds. The recipe is defined in
this server script

EMI displays the recipe as requiring the Cobblestone on the center line:
emi_diamonds

However, there is no such recipe:
emi_false_diamonds

Instead, the cobblestone must be placed in the top-left corner:
emi_true_diamonds

Cross-reports

GregTech Modern: GregTechCEu/GregTech-Modern#2513
KubeJS: KubeJS-Mods/KubeJS#930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe Low priority, may take some time
Projects
None yet
Development

No branches or pull requests

1 participant