Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having a write() method on a Song object is weird #17

Open
emkay opened this issue Apr 22, 2015 · 0 comments
Open

Having a write() method on a Song object is weird #17

emkay opened this issue Apr 22, 2015 · 0 comments

Comments

@emkay
Copy link
Owner

emkay commented Apr 22, 2015

We have song.done() and song.write(). When done() is called we are saying that this song is done and anything that we need to do to finish up constructing the song can now be done. The write() method makes the build directory and outputs the assembler for the sound engine and the song. The reason it needs to be two different calls is that it is possible for you to produce multiple songs. This makes the api confusing because you are calling song.write() not songs.write().

A couple ideas:

  • make a Songs object that is a collection of songs and put the write() method there
  • do not allow multiple songs, and have a single song restraint per file/program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant