Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post pad field #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add post pad field #29

wants to merge 2 commits into from

Conversation

WenqingZong
Copy link
Collaborator

@WenqingZong WenqingZong commented Oct 17, 2024

Fix #17

So, this turns out to be a super easy change. We already have the desired post_speech_pad configuration, it's just named as redemption_time. I've change its name for better readability.

@xd009642
Copy link
Member

So thinking in an airport bar watching my flight grow ever more delayed....

Redemption time and post speech pad aren't the same. The post padding could be less than redemption time and then we'd include the non speech audio that failed redemption.

Redemption is just the time for the VAD to find new speech, padding is the amount of non speech to add after we've decided the VAD is inactive. That does make me think that a post speech pad greater than redemption is logically invalid because we would then have to wait longer to get the audio and we would either have to truncate the pad or keep waiting for audio after the vad is inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post speech padding
2 participants