Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"emulsify" String Replace on INIT #267

Closed
MinhInBlack opened this issue Sep 8, 2022 · 0 comments
Closed

"emulsify" String Replace on INIT #267

MinhInBlack opened this issue Sep 8, 2022 · 0 comments

Comments

@MinhInBlack
Copy link

MinhInBlack commented Sep 8, 2022

emulsify version (see releases): 4.2.2

node version: 16.13

npm (or yarn) version: 8.1.2

What you did:
I executed emulsify init to create a new theme called, "mytheme".

What happened:
Emulsify doesn't change every instance of "emulsify" to their respective theme name. Requires manual change.
Example:
In my rendered theme (mytheme), there are twig functions {{ attach_library('emulsify/default') }} that hasn't been updated to the new theme name. Also in .theme file, my preset theme functions (ex. emulsify_preprocess_page()) does not get updated as well.

Suggested solution:
Maybe have string replace include twig files and .theme files.

@amazingrando amazingrando moved this to Incoming in Emulsify Project Sep 8, 2022
@amazingrando amazingrando moved this from Incoming to Backlog in Emulsify Project Sep 15, 2022
@amazingrando amazingrando moved this from Backlog to Active Sprint in Emulsify Project Jan 26, 2023
@amazingrando amazingrando moved this from Active Sprint to Backlog in Emulsify Project Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

2 participants