-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching favicon #31
Comments
Thanks for your kind words! 🙏 But it probably makes sense to add separate "custom favicon url" settings field, and therefore you would be able to cache it by manually downloading the needed image and converting it to Base64 format |
The new version For example, here's base64 version of the default Google favicon, which can be used in that field:
I believe that such icons should be loaded without any noticable delay. But for future versions I will consider adding a more advanced caching mechanism for network icons as well. |
Actually, I really wonder if your idea of allowing people to define their own custom favicon is not the best one. In particular, it allows users to distinguish between two buttons with the same domain, which is my case (I have two URLs going to YouTube). This seems way better in my eye! |
I'm glad you liked it! Version |
Caching the favicon when adding a new "Open URL" to the menu could reduce initial loading time each time the menu opens on a page. Or maybe cache, at the menu opening, it if it's not referenced in the extension storage.
I would like to take this opportunity to thank you for this extension, which is both useful and well-made!
The text was updated successfully, but these errors were encountered: