Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen new tabs as popup windows #14

Open
l4kr opened this issue Dec 27, 2024 · 4 comments
Open

Reopen new tabs as popup windows #14

l4kr opened this issue Dec 27, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@l4kr
Copy link

l4kr commented Dec 27, 2024

Hi!
Great extension.

Do you think it would be possible to have popups instead of new tabs when I click a link? This would probably be based on the url.
For example if I click a link on github.com to imgur.com it would open a popup automatically instead of having to shift-click.
It could do this especially in pinned tabs or tabs in groups.

@emvaized
Copy link
Owner

That would be a nice addition to the extension, and will take a look if it's achievable. Both "pinned tabs" rule, and custom rules set editable by user (should probably be a list of RegExp expressions).

I'm not sure though, if it should only proccess and reopen newly opened tabs, or be more intrusive and proccess any click event on link on every page.

@emvaized emvaized added the enhancement New feature or request label Dec 28, 2024
@emvaized emvaized changed the title Prevent new tabs Reopen new tabs as popup windows Dec 28, 2024
@l4kr
Copy link
Author

l4kr commented Dec 28, 2024

I think if a tab can be opened in a popup directly then it should be opened that way - aka tabs should be opened as if I Shift-clicked them or draged a URL.

Also, in general, opening a link to a different base URL like *facebook.com/* from *youtube.com/* should open in a popup.
But opening a link to the same base URL should just have the same behavior as the original website intended. (*youtube.com/* to *youtube.com/*)

I think with enough testing this should be mostly unproblematic. I could help with that.

@emvaized
Copy link
Owner

I think if a tab can be opened in a popup directly then it should be opened that way - aka tabs should be opened as if I Shift-clicked them or draged a URL.

My question is: should only new tabs with matching url be reopened as a popup window, or should current tab as well be reopened as a popup window if it's url as about to change to the matching condition?

@l4kr
Copy link
Author

l4kr commented Dec 29, 2024

I think for the most part only new tabs should be reopened. Although I'm curious how would browsing in general feel in both cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants