Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should use the unasync package (and unasync should check for stale files in output dir) #214

Closed
johtso opened this issue Oct 5, 2020 · 3 comments

Comments

@johtso
Copy link
Contributor

johtso commented Oct 5, 2020

unasync.py --check will currently happily allow stale files in _sync. It would be simple enough to make the tool treat the destination directory as fully managed and make sure it strictly matches the output of unasyncing _async with no extra files.

At the same time it would probably be good to improve / start using the unasync package so that effort isn't getting repeated.

See:
python-trio/unasync#66
python-trio/unasync#68
python-trio/unasync#69

@pquentin
Copy link

pquentin commented Oct 5, 2020

We would be happy to collaborate here! @johtso If you get one pull request merged in the python-trio org, you'll be invited as a collaborator to approve pull requests, and we'd be happy to allow you making releases too.

@johtso
Copy link
Contributor Author

johtso commented Oct 5, 2020

@pquentin hope to have a bit of time to do more than just open issues soon :)

@tomchristie
Copy link
Member

I'm going to close this one off for now. No pressing motivation for us to do this given our current workflow.
Am not neccessarily against considering any pull requests switching to unasync.py, but otherwise I don't see any clear need to treat this as an open issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants