Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing documentation for interface list elements #68

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: Missing documentation for interface list elements #68

merged 1 commit into from
Oct 24, 2024

Conversation

TomGoodIdea
Copy link
Member

Correction/Clarification

Summary

I didn't even knew we had something like this until I read the interface loading code.

@TomGoodIdea TomGoodIdea added documentation Improvements or additions to documentation standalone A PR that doesn't require an endless-sky PR to be merged. labels Oct 23, 2024
mOctave
mOctave approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@mOctave mOctave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea this was a thing either.

Grammar looks good. Could maybe use some tweaks, but that would require changing completely unrelated sections of the wiki as well so that's probably best for another PR.

@tibetiroka tibetiroka merged commit a972be9 into endless-sky:master Oct 24, 2024
1 check passed
@TomGoodIdea TomGoodIdea deleted the list-element branch October 24, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibetiroka tibetiroka tibetiroka approved these changes

@mOctave mOctave mOctave approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation standalone A PR that doesn't require an endless-sky PR to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomGoodIdea @tibetiroka @mOctave