Improve multiplayer controls & documentation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a joypad user I would never expect to jump with the Up button on the
D-pad. And if you're using the joystick it's easy to accidentally
trigger the vertical axis and jump by mistake.
Remap the controls as follows:
- Rename the player_{1,2}_up actions in the input map to
player_{1,2}_jump which more accurately reflects the meaning of the
action.
- Remove the unused player_{1,2}_down actions.
- Map the bottom action button (Sony ×, Xbox A, Nintendo B) of each
joypad to the corresponding _jump action.
- Unmap the vertical axis of the joystick from each _jump action.
I decided to leave the D-pad Up button in place because it's harder to
trigger accidentally.
Previously, the instructions would remain on the screen until a keyboard key was pressed. Now that joypad input is supported, hide the instructions when a joypad is used, too. There are two different event types to check for: InputEventJoypadButton for buttons, and InputEventJoypadMotion for joystick axes with fractional movement.
On an AZERTY keyboard, common in French-speaking areas, the keys corresponding to the W/A/D positions on a US keyboard are Z/Q/D. On a Dvorak keyboard, commonly used by nerds who like to make their own lives more difficult and regret the choice they made 20 years ago, the keys are ,/A/E. Add the physical keycodes to the input map. Leave the logical keys in the map so that pressing the key labelled “W” (documented in the on-screen instructions) still works.
Closed
manuq
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Oh thanks, I went to bed thinking if the explanation was good enough and planning to not tell Justin how to use it, ask him to follow the instructions instead.
I was unsure when I switched off the physical keys. I saw that builtin "ui_left" is a generic Left arrow, not the physical one. So I blindly followed that. Luckly you have a dvorak keyboard! The joystick button for jumping is better too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tweaks having tested out the changes from #9 and #8.