Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic service name for ingress #21

Open
michalziobro opened this issue Sep 7, 2022 · 0 comments
Open

Dynamic service name for ingress #21

michalziobro opened this issue Sep 7, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@michalziobro
Copy link
Contributor

When name override is changed there's a need to manually update service name for ingress:

ddhub-client-gateway-helm/example-values.yaml

Line 169 in 5bca635

serviceName: ddhub-client-gateway

ddhub-client-gateway-helm/templates/ingress.yaml

Line 56 in 5bca635

serviceName: {{ .backend.serviceName }}

This could be replaced by:

ddhub-client-gateway-helm/templates/service.yaml

Line 4 in 5bca635

name: {{ include "ddhub-client-gateway-api.fullname" . }}

@michalziobro michalziobro added the enhancement New feature or request label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michalziobro