Skip to content
This repository has been archived by the owner on Mar 17, 2019. It is now read-only.

The right thing to do when you catch an exception is never to throw an exception #40

Open
jaypoulz opened this issue Jul 1, 2015 · 0 comments
Labels

Comments

@jaypoulz
Copy link
Contributor

jaypoulz commented Jul 1, 2015

There are a few places in @jdaigneau's API wrapper where a catch block throws the exception it catches. The technical term for this is wack.

You should either:

  1. not catch the exception (and allow the calling functions to catch them)
  2. handle the exception gracefully (this could mean notifying the user about what went wrong, logging events, restarting a service, etc.)
@jaypoulz jaypoulz added the bug label Jul 1, 2015
@jaypoulz jaypoulz changed the title The right thing to do when you catch an except is never to throw an exception The right thing to do when you catch an exception is never to throw an exception Jul 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants