fail if we find any async functions #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdonst
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Yeah, this is much more descriptive. Now the error looks like:
Oops, something went wrong
Error: illegal_async_function: doc-content must be a Function not an AsyncFunction
at renderTemplate (file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/ssr/index.mjs:203:13)
at expandTemplate (file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/ssr/index.mjs:145:16)
at file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/ssr/index.mjs:35:15
at walk (file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/ssr/lib/walk.mjs:2:7)
at walk (file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/ssr/lib/walk.mjs:14:11)
at walk (file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/ssr/lib/walk.mjs:14:11)
at processCustomElements (file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/ssr/index.mjs:27:5)
at html (file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/ssr/index.mjs:74:9)
at html (file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/arc-plugin-enhance/src/http/any-catchall/router.mjs:170:24)
at Object.api (file:///Users/simonmacdonald/Developer/macdonst/tmp/async-throw-test/node_modules/@enhance/arc-plugin-enhance/src/http/any-catchall/router.mjs:216:22)
So it actually points to the root cause.
|
I could see the argument to allow for |
|
@brianleroux no, elements have to be sync. If folks need to fetch data they need to do it before the render method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per https://discord.com/channels/1012099764713705472/1012435743571988560/1256006651073396899
detects and fails if we encounter an
AsyncFunctionin theelementsmap