Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Styles v7 #45

Closed
colepeters opened this issue Mar 25, 2024 · 3 comments
Closed

Enhance Styles v7 #45

colepeters opened this issue Mar 25, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@colepeters
Copy link
Member

Proposed breaking changes for next major version of Enhance Styles

Emit only custom properties

Users should be able to configure Enhance Styles to only emit custom properties so that folks who want to use those without utility classes may do so.

Current modules which export custom styles:

  • type scale
  • space scale
  • theme
  • color

This would need to be compatible with another desired change, which is:

Make files, config, and output 1:1

Users should be able to opt out of any modules they don't require. Currently the styleguide.json allows for configuring some fields; most have defaults if no configuration is specified, some (like color) do not. We should unify the configuration file with the range of available modules for utility classes, such that all modules are included by default, but users can choose to opt out of certain modules if they prefer. For example, to configure the type scale but opt out of background- classes:

{
  "typeScale": {},
  "background": false,
}
@colepeters colepeters added the enhancement New feature or request label Mar 25, 2024
@colepeters colepeters changed the title Breaking changes: emit only custom properties; 1:1 files, config, output Enhance Styles v6 Mar 25, 2024
@colepeters colepeters changed the title Enhance Styles v6 Enhance Styles v7 Mar 25, 2024
@colepeters
Copy link
Member Author

colepeters commented Mar 26, 2024

Separation of type styles & body reset styles

https://discord.com/channels/1012099764713705472/1059964929681141870/1222028737747353621

@colepeters
Copy link
Member Author

@colepeters
Copy link
Member Author

Closing this in favour of this project; issues will be created from that project as they are take on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants