Merge pull request #385 from ensan-hcl/feature/misconversion_report

[Feature] 誤変換のレポート操作を分かりやすくした
ensan-hcl · Jan 14, 2024 · 4678407 · 4678407
2 parents c5b8b80 + 55cfd78
commit 4678407
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 2 deletions.
diff --git a/AzooKeyCore/Sources/KeyboardViews/View/KeyboardBar/ResultBar.swift b/AzooKeyCore/Sources/KeyboardViews/View/KeyboardBar/ResultBar.swift
@@ -179,12 +179,19 @@ struct ResultContextMenuView: View {
                 action.notifyForgetCandidate(candidate, variableStates: variableStates)
             }
         }
-        if SemiStaticStates.shared.hasFullAccess {
-            Button("誤変換を報告", systemImage: "exclamationmark.bubble") {
+        Section(SemiStaticStates.shared.hasFullAccess ? "フィードバックを送信" : "フルアクセスが必要です") {
+            Button("意図した変換ではない", systemImage: "exclamationmark.bubble") {
                 Task { @MainActor in
                     await action.notifyReportWrongConversion(candidate, index: index, variableStates: variableStates)
                 }
             }
+            .disabled(!SemiStaticStates.shared.hasFullAccess)
+            Button("欲しい変換がない", systemImage: "questionmark.bubble") {
+                Task { @MainActor in
+                    await action.notifyReportWrongConversion(candidate, index: index, variableStates: variableStates)
+                }
+            }
+            .disabled(!SemiStaticStates.shared.hasFullAccess)
         }
         #if DEBUG
         Button("デバッグ情報を表示する", systemImage: "ladybug.fill"){

diff --git a/Resources/Localizable.xcstrings b/Resources/Localizable.xcstrings
@@ -4469,6 +4469,17 @@
         }
       }
     },
+    "フィードバックを送信" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Send feedback"
+          }
+        }
+      }
+    },
     "フォントはiOSで標準的に利用される「ヒラギノ明朝」を用いています。明朝体の字形は手書きする際の規範的な字形と必ずしも一致しません。ご了承ください。" : {
       "localizations" : {
         "en" : {
@@ -4663,6 +4674,17 @@
         }
       }
     },
+    "フルアクセスが必要です" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Requires full access"
+          }
+        }
+      }
+    },
     "フルアクセスが必要な機能を使う" : {
       "localizations" : {
         "en" : {
@@ -6944,6 +6966,17 @@
         }
       }
     },
+    "意図した変換ではない" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Unexpected candidate"
+          }
+        }
+      }
+    },
     "手順を見る" : {
       "localizations" : {
         "en" : {
@@ -8091,6 +8124,17 @@
         }
       }
     },
+    "欲しい変換がない" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "No expected candidate"
+          }
+        }
+      }
+    },
     "正しくない形式のファイルです" : {
       "localizations" : {
         "en" : {