Use consistent rego syntax in prep for opa 1.0 #2281
Draft
+193
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
=======================================
Coverage 72.79% 72.79%
=======================================
Files 89 89
Lines 7687 7687
=======================================
Hits 5596 5596
Misses 2091 2091
Flags with carried forward coverage won't be shown. Click here to find out more. |
The idea here is that once we update to opa 1.0 we'll need to always use the new `deny contains foo if` syntax. This change is supposed to make it easier by using that syntax consistently now. It requires importing `rego.v1` everywhere, but we do that consistently for all the rego in ec-policies, so let's also do it here also. See also enterprise-contract#2274 which I'd like to rebase on this once it's merged.
simonbaird
force-pushed
the
prep-test-rego-for-opa-1.0
branch
from
473f065 to
8de0bb9
Compare
|
For some reason I can't run acceptance tests locally, so it's slow going to get all the small snapshot changes done. |
|
Note the acceptance tests are not actually passing, despite what it looks like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that once we update to opa 1.0 we'll need to always use the new
deny contains foo ifsyntax. This change is supposed to make it easier by using that syntax consistently now.It requires importing
rego.v1everywhere, but we do that consistently for all the rego in ec-policies, so let's also do it here also.See also #2274 which I'd like to rebase on this once it's merged.
Ref: https://issues.redhat.com/browse/EC-1130