Refactor from % string formatting to f-strings in every module.
#657
Assignees
Labels
good first issue
Good for newcomers
Comments
|
I looked for the use location by git grep -n '%[sdxXorfFeEgGc]' I will split modification into several PRs by file or dir. result |
|
Thank you for your investigation. Please note that the grep results mentioned above include items like Happy contributing! |
|
@junkmd Thank you for your support. I investigated by Result |
|
Hi @newwingbird, Thanks for your quick response. I noticed that |
|
Okay, In addition, |
I might have missed it, but if
That's right. |
Merged
|
We became confused about the combination of
As shown below, these patterns are equivalent regardless of the chosen style. >>> foo = 123
>>> "...\\%s..." % foo
'...\\123...'
>>> f"...\\{foo}..."
'...\\123...'
>>> r"...\%s..." % foo
'...\\123...'
>>> rf"...\{foo}..."
'...\\123...'
>>> However, to keep changes minimal, let’s ensure the number of backslashes remains the same before and after changes within the scope of this issue. We can decide whether to standardize them after this issue is closed. |
|
The Can you accept to limit the scope of this issue to the |
|
I think so. We should replan the scope of issues. |
|
Thank you for agreeing. I have removed "Others" from the kanban and limited the to-do list to only the Please keep up the great work as a contributor! |
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We could replace
%string formatting with f-strings wherever applicable, as was done in #654.For details on f-string syntax, refer to the Python official documentation.
Most of the changes should follow these patterns:
"...%s..." % foowithf"...{foo}...""...%r..." % foowithf"...{foo!r}...""...%x..." % foowithf"...{foo:x}...""...%d..." % foowithf"...{foo:d}...""...\\%s..." % foowithf"...\\{foo}..."r"...\%s..." % foowithrf"...\{foo}..."There’s NO need to modify placeholders in logger method calls, as shown below.
comtypes/comtypes/__init__.py
Lines 137 to 141 in 083c19e
We welcome keeping changes as small as possible per pull request, as it makes it easier for reviewers to check the changes.
If your PR addresses multiple rules or files, reviewers might consider it a large change and suggest splitting it into multiple PRs.
TODO list
Under the
comtypes/...comtypes/_comobject.pycomtypes/_memberspec.pycomtypes/_post_coinit/_cominterface_meta_patcher.pycomtypes/automation.pycomtypes/client/_code_cache.pycomtypes/client/_constants.pycomtypes/client/_events.pycomtypes/client/_generate.pycomtypes/client/lazybind.pycomtypes/errorinfo.pycomtypes/server/inprocserver.pycomtypes/server/register.pycomtypes/server/w_getopt.pycomtypes/tools/codegenerator/codegenerator.pycomtypes/tools/codegenerator/helpers.pycomtypes/tools/codegenerator/packing.pycomtypes/tools/tlbparser.pycomtypes/tools/typedesc.pycomtypes/typeinfo.pycomtypes/viewobject.pyUnder the
comtypes/test/...comtypes/test/__init__.pycomtypes/test/test_BSTR.pycomtypes/test/test_avmc.pycomtypes/test/test_casesensitivity.pycomtypes/test/test_collections.pycomtypes/test/test_comserver.pycomtypes/test/test_createwrappers.pycomtypes/test/test_dispinterface.pycomtypes/test/test_excel.pycomtypes/test/test_outparam.pycomtypes/test/test_safearray.pycomtypes/test/test_sapi.pycomtypes/test/test_server.pycomtypes/test/test_urlhistory.pycomtypes/test/test_variant.pycomtypes/test/test_word.pyThe text was updated successfully, but these errors were encountered: