Replace type alias with compatible symbols that can be imported from ctypes.wintypes.
#662
Labels
good first issue
Good for newcomers
Milestone
Comments
junkmd
pushed a commit
that referenced
this issue
Dec 9, 2024
* Replace alias definitions with ctypes.wintypes imports * Fix formatting in GUID.py and git.py * Add noqa to DWORD import in __init__.py Linter check disabled on import statement, no direct use of import in module but tests depend on DWORD import in __init__.py * Fix formatting in __init__.py * Fix space formatting in __init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The line in
__init__.pydefiningDWORDas an alias forc_ulonghas been present since the project’s earliest commit, 938fbd5.comtypes/comtypes/__init__.py
Line 75 in 083c19e
On the other hand, in commit 56908fd, which added
shelllink.pytwo years later,DWORDwas imported fromctypes.wintypes.comtypes/comtypes/shelllink.py
Line 4 in 083c19e
The originator of
ctypesandcomtypesis the same person, and these libraries have historically evolved together, which has led to differences in symbol definitions like this.Now, however, defining these aliases independently holds little value, so we could replace them where possible.
We welcome keeping changes as small as possible per pull request, as it makes it easier for reviewers to check the changes.
If your PR addresses multiple rules or files, reviewers might consider it a large change and suggest splitting it into multiple PRs.
The text was updated successfully, but these errors were encountered: