Skip to content

Commit

Permalink
Require apptools 5.3 or later, Python 3.8 or later (#584)
Browse files Browse the repository at this point in the history
This PR updates the apptools dependency to apptools >= 5.3, and deals
with various pieces of fallout from that change:

Detailed changes:

- require `apptools >= 5.3`, which contains some fixes that we need for
some upcoming bugfixes on this repository (see #583)
- require `apptools[preferences]` rather than just plain `apptools`,
since version 5.3.0 of `apptools` no longer declares `configobj` as an
explicit dependency, and Envisage preferences depend on `configobj`
- similarly, require `configobj` explicitly in `etstool.py`, since EDS
doesn't support optional requirements
- require Python >= 3.8, since `apptools` now also requires Python >=
3.8, and `apptools >= 5.3.0` is not available for Python 3.7
  • Loading branch information
mdickinson authored Jul 17, 2024
1 parent 4ec68a4 commit 9c520cc
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-with-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest']
python-version: ['3.7', '3.8', '3.10', '3.11']
python-version: ['3.8', '3.10', '3.11']

runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ framework. You are free to use:
Prerequisites
-------------

The supported versions of Python are Python >= 3.7. Envisage requires:
The supported versions of Python are Python >= 3.8. Envisage requires:

* `apptools <https://pypi.org/project/apptools/>`_
* `traits <https://pypi.org/project/traits/>`_
Expand Down
1 change: 1 addition & 0 deletions etstool.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@

dependencies = {
"apptools",
"configobj",
"coverage",
"enthought_sphinx_theme",
"pyface",
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name = 'envisage'
version = '7.0.3'
description = 'Extensible application framework'
readme = 'README.rst'
requires-python = '>= 3.7'
requires-python = '>= 3.8'
license = {file = 'LICENSE.txt'}
authors = [{name = 'Enthought', email = '[email protected]'}]
keywords = ['extensible', 'plugin', 'application', 'framework']
Expand All @@ -28,7 +28,7 @@ classifiers = [
'Topic :: Software Development :: User Interfaces',
]
dependencies = [
'apptools',
'apptools[preferences]>=5.3',
'pyface',
'setuptools',
'traits>=6.2',
Expand Down

0 comments on commit 9c520cc

Please sign in to comment.