Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbars are not created in pyface 8.0 #1251

Open
johannesloibl opened this issue Jun 12, 2023 · 2 comments · May be fixed by bpteague/pyface#1 or #1260
Open

Toolbars are not created in pyface 8.0 #1251

johannesloibl opened this issue Jun 12, 2023 · 2 comments · May be fixed by bpteague/pyface#1 or #1260

Comments

@johannesloibl
Copy link
Contributor

Hey,

there seems to be a copy&pasta error:

pyface/pyface/ui/qt/application_window.py

Line 159 in 46f7009

self._create_status_bar(self.control) 

@observe("tool_bar_managers.items")
def _update_tool_bar_managers(self, event):
    if self.control is not None:
        # Remove the old toolbars.
        for child in self.control.children():
            if isinstance(child, QtGui.QToolBar):
                self.control.removeToolBar(child)
                child.deleteLater()

        # Add the new toolbars.
        if event.new is not None:
            self._create_status_bar(self.control)

The trait change handler for tool bars is creating the status bar instead of the tool bars ;)
@jirhiker
Copy link

jirhiker commented Apr 9, 2024

I can confirm this is an issue.

toolbars were not displaying in my envisage app. Changing the code to

@observe("tool_bar_managers.items")
def _update_tool_bar_managers(self, event):
    if self.control is not None:
        # Remove the old toolbars.
        for child in self.control.children():
            if isinstance(child, QtGui.QToolBar):
                self.control.removeToolBar(child)
                child.deleteLater()

        # Add the new toolbars.
        if event.new is not None:
            #self._create_status_bar(self.control)
             self._create_tool_bar(self.control)

appeared to resolve the issue.

Is there a timeline for when pyface 8.0.X will be released to permanently fix this bug?

Thanks

This was referenced Feb 9, 2025
Open
Open
@bpteague
Copy link
Contributor

bpteague commented Feb 9, 2025

PR #1260 submitted to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix application toolbars bpteague/pyface
Fix application toolbars bpteague/pyface
3 participants
@jirhiker @bpteague @johannesloibl