Traits 6.4.2 bugfix release #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In traitsui, traitsui.__version__ has been deprecated and should be
replaced with importlib.metadata.version('traitsui'). The deprecation
warning raised have also caused test_edit_not_given in
traits/traits/tests/test_configure_traits.py to fail as mentioned in
#1745 . Since the version check is a temporary check to address the
dependency of traits on traits ui and is no longer need, the current PR
fixed this issue by removing all version checks related to
_traitsui_helpers.py.
Closes #1745
Co-authored-by: Chengyu Liu <[email protected]>
(cherry picked from commit 60f918e)
mdickinson
force-pushed
the
release/6.4.2-bis
branch
from
f0a595d
to
f0fdb86
Compare
corranwebster
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (against the maint/6.4 branch) is aimed at a 6.4.2 bugfix release.
Key changes:
The PR is pretty horrendous to review en masse thanks to the changelog updates, but it should be possible to review it commit by commit.
@corranwebster Would you have bandwidth for review at some point? (Feel free to unassign if not.)